Overhaul stats: Remove internal non-labeled metrics #1584
Merged
+494
−929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore pkg We only used labeled metric internally, althougth the APi exposes global aggregate metrics (without labels. They are calculated from the labeled metrics.
The IP faimly related to the counter (inet or inet6) dependos on the server binding IP. If the server is listening on a inet6 IP, then inet6 lreated counters should be increased.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1584 +/- ##
===========================================
- Coverage 84.79% 84.71% -0.09%
===========================================
Files 289 288 -1
Lines 21709 21498 -211
Branches 21709 21498 -211
===========================================
- Hits 18408 18211 -197
+ Misses 2981 2966 -15
- Partials 320 321 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josecelano
force-pushed
the
1581-overhaul-stats-remove-internal-non-labeled-metrics
branch
from
31b908c to
a552482
Compare
Member
Author
|
ACK a552482 |
This was referenced Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove internal non-labeled metrics.
Subtasks
http-tracker-corepackage.udp-tracker-corepackage.udp-tracker-serverpackage.